Open aygold92 opened 5 years ago
Please see RPDK resource_generator.py (permalink) for additional semantic validations that should be implemented:
format
and pattern
together may be nonsensicalminimum
and exclusiveMinimum
together may be nonsensical, same with maximum
minimum
< maximum
(minimum
== maximum
makes no sense either, and should use const
instead), same for exclusive ones. added complication: perform this validation with minimum
and exclusiveMaximum
and vice versa.While primaryIdentifier
can be an array (of pointers), a pointer within that array should not point to an array (at least, that's not currently supported). This is not checked during registration but fails (opaquely) at runtime.
added some of these to cfn validate
:
https://github.com/aws-cloudformation/cloudformation-cli/pull/663, https://github.com/aws-cloudformation/cloudformation-cli/pull/668, https://github.com/aws-cloudformation/cloudformation-cli/pull/675, https://github.com/aws-cloudformation/cloudformation-cli/pull/729
Update (3/16/2020)
primaryIdentifier
can only refer to a property which itself is a String or Number.primaryIdentifier
existsPlease add more as we come across them