Closed johnttompkins closed 5 years ago
Is this basically aws-cloudformation/aws-cloudformation-rpdk#81?
Yes, although with this change, something you mentioned in that issue like:
"identifiers": [
"#/properties/Arn",
["#/properties/Foo", "#/properties/Bar"],
"#/properties/URL"
]
would have to be
"identifiers": [
["#/properties/Arn"],
["#/properties/Foo", "#/properties/Bar"],
["#/properties/URL"]
]
Not sure if this would be a pain point for customer
I don't think it's a big deal as long as the examples are obvious. Be good to close that issue once this is merged.
Issue #, if available: https://github.com/aws-cloudformation/aws-cloudformation-rpdk/issues/81
Description of changes: This changes the structure for identifiers so that compound identifiers are valid. Previously, only single property identifiers were valid. Before:
In the above schema, if two resource properties
identifier2a
andidentifier2b
together uniquely identify a resource, there is no way of expressing that with a single JSON pointer. The proposed change allows for that and is also in line with what CloudFormation is expecting when pulling down schemas.Now:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.