aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.
Apache License 2.0
90 stars 38 forks source link

Remove jar shading & http->https #57

Closed johnttompkins closed 4 years ago

johnttompkins commented 4 years ago

Issue #, if available:

Description of changes: Builds were failing on unit tests because of 301 redirects from the http json schema link. The everit library doesn't handle the redirects, so it tries to parse the html response and errors out because it isn't valid json. Changing back to https fixes the issue. This also unshades the jar in anticipation of pubishing this to the central repo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rjlohan commented 4 years ago

To clarify;

--2019-11-17 20:21:38--  http://json-schema.org/draft-07/schema
Resolving json-schema.org (json-schema.org)... 185.199.111.153, 185.199.110.153, 185.199.108.153, ...
Connecting to json-schema.org (json-schema.org)|185.199.111.153|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://json-schema.org/draft-07/schema [following]
--2019-11-17 20:21:38--  https://json-schema.org/draft-07/schema
Connecting to json-schema.org (json-schema.org)|185.199.111.153|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4885 (4.8K) [application/octet-stream]

The http:// endpoint has been redirected to https:// so this is the right fix.