search

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.
Apache License 2.0
95 stars 38 forks source link

Bumping version #73

Closed johnttompkins closed 4 years ago

johnttompkins commented 4 years ago

Issue #, if available:

Description of changes: Bumping version so I can have an updated dependency to make changes in the java plugin related to #64. I removed the scm tag as we don't need the tag (rpdk java library does not have it). Becomes one less thing to worry about updating.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tobywf commented 4 years ago

Can we wait for #61 and #69 ?

tobywf commented 4 years ago

See also https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/220

johnttompkins commented 4 years ago

Yeah we can hold off until we get those reviewed

johnttompkins commented 4 years ago

Can we wait for #61 and #69 ?

At least for #61 we can probably skip holding off: https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/pull/61#issuecomment-559233995

Did this mainly just to unblock the wrapper work

aygold92 commented 4 years ago

Can we wait for #61 and #69 ?

what's the downside of doing a bunch of version bumps?

tobywf commented 4 years ago

effort

johnttompkins commented 4 years ago

Looks like #69 is pending some PR and service side changes which might take a bit, so I'll go ahead and merge this in to unblock https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/222 and https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/220