Incorrect JSON Schema draft URI

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.

Apache License 2.0

95 stars 38 forks source link

Incorrect JSON Schema draft URI #83

Closed iann0036 closed 4 years ago

iann0036 commented 4 years ago

According to the spec, the draft-07 schema URI should begin with http:// and not https:// (schema ID does not necessarily mean the network location where the resource is stored).

So I believe the references should be changed to reflect this.

PatMyron commented 4 years ago

looks like they were flipped here: https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/pull/57

johnttompkins commented 4 years ago

If if remember correctly, there was some justification for the http->https changes in the references, as the library we used did not handle http 301 redirects returned by json-schema.org.

This issue https://github.com/json-schema-org/json-schema-org.github.io/issues/236 seems related and was resolved around the same time as #57 . Anyways, I changed them back and it looks to be working correctly with all tests passing. Will send out a PR.