search

aws-cloudformation / community-registry-extensions

MIT No Attribution
86 stars 27 forks source link

Add S3_AccessControl hook #238

Closed mrinaudo-aws closed 1 year ago

mrinaudo-aws commented 1 year ago

Issue #, if available:

Description of changes: Add S3_AccessControl hook.

Unit tests excerpts

[...]
[INFO] Running com.awscommunity.s3.accesscontrol.PreUpdateHookHandlerTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.354 s -- in com.awscommunity.s3.accesscontrol.PreUpdateHookHandlerTest
[INFO] Running com.awscommunity.s3.accesscontrol.PreCreateHookHandlerTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 s -- in com.awscommunity.s3.accesscontrol.PreCreateHookHandlerTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[...]
[INFO] --- jacoco:0.8.10:check (jacoco-check) @ awscommunity-s3-accesscontrol-handler ---
[...]
[INFO] Analyzed bundle 'awscommunity-s3-accesscontrol-handler' with 5 classes
[INFO] All coverage checks have been met.

Contract tests excerpts

[...]
5 passed, 2 skipped, 17 deselected
[...]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mrinaudo-aws commented 1 year ago

Very thorough as always! Only a few minor comments.

Are you going to add this to the pipeline in a separate PR?

I can add an updated pipeline template here as well.