Closed paulosergio-jnr closed 5 months ago
Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?
It was just because the -headers
suffix in the directory's name seemed to be something very specific.
WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions
?
Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?
It was just because the
-headers
suffix in the directory's name seemed to be something very specific.WDYT of merging both examples, applying the comments above, and changing the name to just
cloudfront-functions
?
If the differences are not too significant I'm ok with that. We could also merge with the cloudfront
app and just have one
Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?
It was just because the
-headers
suffix in the directory's name seemed to be something very specific. WDYT of merging both examples, applying the comments above, and changing the name to justcloudfront-functions
?If the differences are not too significant I'm ok with that. We could also merge with the
cloudfront
app and just have one
After evaluating the three different examples regarding CloudFront, I merged both that are focused on deploying CloudFront Functions as cloudfront-functions
and let the cloudfront
as is given these points:
cloudfront
example deploys the cloudfront distribution in a simpler way compared to the other two.cloudfront
example has a considerable more complex comment to create the cloudfront distribution.cloudfront
example is using pre-created resources, as the other two examples are creating the whole environment from scratch.What do you think @ericzbeard ?
Issue: https://github.com/aws-cloudformation/iac-model-evaluation/issues/12
Description of changes: Added CloudFront Functions example with both request and response functions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.