aws-cloudformation / iac-model-evaluation

MIT No Attribution
9 stars 16 forks source link

Added CloudFront Functions example #22

Closed paulosergio-jnr closed 5 months ago

paulosergio-jnr commented 6 months ago

Issue: https://github.com/aws-cloudformation/iac-model-evaluation/issues/12

Description of changes: Added CloudFront Functions example with both request and response functions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

paulosergio-jnr commented 5 months ago

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific.

WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

ericzbeard commented 5 months ago

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific.

WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

If the differences are not too significant I'm ok with that. We could also merge with the cloudfront app and just have one

paulosergio-jnr commented 5 months ago

Why did we go with cloudfront-functions as the name? Why not expand on the existing cloudfront sample?

It was just because the -headers suffix in the directory's name seemed to be something very specific. WDYT of merging both examples, applying the comments above, and changing the name to just cloudfront-functions?

If the differences are not too significant I'm ok with that. We could also merge with the cloudfront app and just have one

After evaluating the three different examples regarding CloudFront, I merged both that are focused on deploying CloudFront Functions as cloudfront-functions and let the cloudfront as is given these points:

What do you think @ericzbeard ?