search

aws-cloudformation / rain

A development workflow tool for working with AWS CloudFormation.
Apache License 2.0
785 stars 71 forks source link

v1.9.0 #389

Closed ericzbeard closed 4 months ago

ericzbeard commented 4 months ago

Leaning into rain forecast in this release. Made it possible to suppress warnings, and added a number of new checks related to auto scaling groups.

Also added a mode to the interactive rain build command to ask bedrock arbitrary questions and include a file for reference.

ericzbeard commented 4 months ago

Sorry for the late review. Real busy week. PR looks great, I tested as much as I could.

One thing I noticed is that forecast does not validate passed param values. So if I pass a param that does not match the "AllowedPattern" for example, it still says "Clear skies!". Might be a nice to have in the future, but other than that it looked great! Good job!

I see this as the linter's job. We're not trying to replace cfn-lint, which makes all of the offline checks it can based on template syntax. Rain forecast will handle anything that requires us to inspect the account.

Thanks for the review!