FIX: failed to ap-northeast-1 using Mac

aws-containers / amazon-ecs-exec-checker

🚀 Pre-flight checks for ECS Exec

MIT No Attribution

886 stars 141 forks source link

FIX: failed to ap-northeast-1 using Mac #54

Closed masayoshi644 closed 2 years ago

masayoshi644 commented 2 years ago

I've fixed this bug report! ( #53 ) Here bug is from this #48, so I modified the codes so that It doesn't use sed.

Please review it.

masayoshi644 commented 2 years ago

@adamjkeller @InbarRose @thelateperseus Hi, there! How is that going? If the PR passes your check, please approve it.

thelateperseus commented 2 years ago

@paprika-mah I'm not a maintainer of this repository so I can't merge this PR. But I can confirm that your updated script still works for me on Windows using cygwin.

masayoshi644 commented 2 years ago

@thelateperseus
Thank you for replying and checking👍

@toricls Hi, Tori-san🐦 ! I wanna ask you; Have you still been a maintainer of the AWS repo? If so, please review it🙇🏼‍♂️

adamjkeller commented 2 years ago

hey @paprika-mah! Thanks for the PR, I am going to check out why the build is failing and will get this merged very soon. Apologies for the delay!