Fix exit code and replicaset panic

aws-containers / kubectl-detector-for-docker-socket

A Kubectl plugin that can detect if any of your workloads or manifest files are mounting the docker.sock volume

Apache License 2.0

175 stars 21 forks source link

Closed konoui closed 1 year ago

konoui commented 1 year ago

address #9 , #10

I addressed issues at the same time since a fix of #10 is related to #9 . If separating PR is required, please let me know.

chage test directory to tests to match Makefile and README.md
check a condition for each resource in the same workload
add checking a condition of daemonset
support ReplicaSet to avoid panic
- there are several ways to avoid it e.g.) skip replicaset check, fallback to the pod handling, but I think adding it looks simple and useful.

rothgar commented 1 year ago

Thanks so much for the PR and open issues. I'll test this next week.