Should we also detect mounts of dockershim.sock which is being deprecated?

aws-containers / kubectl-detector-for-docker-socket

A Kubectl plugin that can detect if any of your workloads or manifest files are mounting the docker.sock volume

Apache License 2.0

175 stars 21 forks source link

Should we also detect mounts of dockershim.sock which is being deprecated? #2

Closed RobertNorthard closed 2 years ago

RobertNorthard commented 2 years ago

The tool currently does not detect resources that mount the dockershim.sock, which is being deprecated and removed. Customers might mount this socket for various cluster tools (e.g. https://github.com/aws/amazon-vpc-cni-k8s/issues/1397).

trunet commented 2 years ago

I guess this was done on this commit: https://github.com/aws-containers/kubectl-detector-for-docker-socket/commit/69289c80f80426cafad895a2de0900df8548aa8b

rothgar commented 2 years ago

I think this has already been done but feel free to comment again if it's still a problem.