aws-containers / retail-store-sample-app

Sample application for demonstrating container platforms and related technology
MIT No Attribution
268 stars 302 forks source link

fix: Properly handle public ECR images in App Runner Terraform #574

Closed niallthomson closed 4 months ago

niallthomson commented 4 months ago

Issue #, if available: N/A

Description of changes: The App Runner Terraform was failing to deploy properly with ECR Public images due to providing authentication configuration only suitable for ECR private repositories. This authentication configuration is now passed in conditionally depending on the repository type.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.