aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.44k stars 258 forks source link

Support state less APIs #1450

Closed brucegucode closed 1 year ago

brucegucode commented 2 years ago

Is your feature request related to a problem? It's not related to a problem

Describe the solution you'd like Not sure if it's possible for k8s, but there are some state less APIs from say RDS service. like rebootdbinstance/cluster api. These are only status of db, not related to any Spec of an actual db instance. Not sure if we can achieve this through ACK framework.

probably customer can set status of db instance instead of spec ? then ACK can call this reboot api ? Similar thing i can think of like failover api of a maz instance or multi-az cluster.

Describe alternatives you've considered A description of any alternative solutions or features you've considered.

a-hilaly commented 2 years ago

I don't think ACK should deal with the data plane for any service even thought it sounds simple and straightforward to implement (and i don't believe it's the case here). I just can't imagine having to deal with EC2 boot/reboot operations, manage s3 objects, dynamodb table raws etc... unless if we want to create a new set of controller that will exclusively deal with the data plane (and complete the existing controllers)

probably customer can set status of db instance instead of spec ? then ACK can call this reboot api ?

I always think about Status as the field users should never modify manually with - and most of the kubernetes controllers respect this pattern so it can a little bit not intuitive to expect users to modify the status manually.

Spec/Status conventions: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

eks-bot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-prow[bot] commented 1 year ago

@ack-bot: Closing this issue.

In response to [this](https://github.com/aws-controllers-k8s/community/issues/1450#issuecomment-1426943007): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Provide feedback via https://github.com/aws-controllers-k8s/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ack-bot commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-prow[bot] commented 1 year ago

@ack-bot: Closing this issue.

In response to [this](https://github.com/aws-controllers-k8s/community/issues/1450#issuecomment-1470037269): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Provide feedback via https://github.com/aws-controllers-k8s/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.