aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.39k stars 253 forks source link

Add client side validations from SDK to CRD #1657

Open surajkota opened 1 year ago

surajkota commented 1 year ago

Is your feature request related to a problem? api-2.json file has information about constraints on the fields, e.g. length, number of items, pattern of the value. e.g. SageMaker Batch Transform Job Name

"TransformJobName":{
  "type":"string",
  "max":63,                                        --> +kubebuilder:validation:MaxLength
  "min":1,                                         --> +kubebuilder:validation:MinLength
  "pattern":"^[a-zA-Z0-9](-*[a-zA-Z0-9]){0,62}"    --> +kubebuilder:validation:Pattern
},

These validations are done by the aws-sdk-go and each service might catch the errors and set conditions. Adding validations at CRD level will:

Describe the solution you'd like Add kubebuilder validations for the shapes to CRD.

Describe alternatives you've considered A description of any alternative solutions or features you've considered.

ack-bot commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

surajkota commented 1 year ago

/remove-lifecycle stale

surajkota commented 1 year ago

/remove-lifecycle rotten

surajkota commented 1 year ago

/lifecycle frozen