aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.39k stars 253 forks source link

Sagemaker model tag updates not applied by resource sync #1731

Open MatthewHou opened 1 year ago

MatthewHou commented 1 year ago

Describe the bug A model is created and managed by Sagemaker ACK controller. We are trying to update the tags of this model. The changes to the model tag are not reflected in AWS console. But the live manifest of this model shows Resource synced successfully

Steps to reproduce

  1. Create a model manifest with some tags specified. Apply the manifest.
  2. Edit the live manifest to add an additional tag.
  3. Check the model tags in the AWS console

Expected outcome Model tags in the AWS console should be updated

Environment

surajkota commented 1 year ago

HI @MatthewHou, please refer to https://github.com/aws-controllers-k8s/community/issues/1732. Is this issue also from one of your colleague?

MatthewHou commented 1 year ago

@surajkota #1732 appears to be a different issue. I'm working with a newly created Sagemaker model / endpoint, not a migrated one. Is tag updating a know limitation in all resources managed by Sagemaker ACK controller?

surajkota commented 1 year ago

Yes

ack-bot commented 10 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 8 months ago

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot commented 6 months ago

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-prow[bot] commented 6 months ago

@ack-bot: Closing this issue.

In response to [this](https://github.com/aws-controllers-k8s/community/issues/1731#issuecomment-1940559008): >Rotten issues close after 60d of inactivity. >Reopen the issue with `/reopen`. >Provide feedback via https://github.com/aws-controllers-k8s/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ack-bot commented 3 weeks ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale