Support tag updates in SageMaker resources

[josehui]

Describe the bug We recently migrated from old sagemaker operator to the new ACK controller. When we tried to update the resource tags by editing the manifest, it is not reflected on SageMaker and kubectl describe shows below error

Conditions: Message: not implemented Status: True Type: ACK.Terminal Last Transition Time: 2023-03-16T11:37:07Z Message: Resource not synced Reason: resource is in terminal condition Status: False Type: ACK.ResourceSynced Events:

Steps to reproduce

1. Migrate sagemaker CRs from old operator following here
2. Export new manifest e.g. model.yaml
3. Edit tags field in manifest
4. Apply manifest again kubectl apply -f model.yaml

Expected outcome SageMaker CRs can be updated and reflected in aws console.

Environment Prod, Staging

• Kubernetes version 1.22
• Using EKS (yes/no), if so version? yes. 1.22
• AWS service targeted (S3, RDS, etc.) SageMaker

[a-hilaly]

/cc @aws-controllers-k8s/sagemaker-maintainer

[surajkota]

This is a known limitation. Tags are only supported on create in sagemaker controller. Updating tags is not supported yet. afaik, same was the case with old operator. Is this a blocker?

Also, updating model and endpoint config is not supported since this operation is not available on service side.

We will find a place to document this.

@A-Hilaly thanks for tagging. Is the common tag handling mechanism implemented now?

[josehui]

Thanks @surajkota. We are aware that model/ endpointconfig is immutable. We will update the tags manually for now but look forward to the new feature.

[surajkota]

Ack, Thank you

[ack-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

[surajkota]

/lifecycle frozen

[mwm5945]

also interested in this :)