aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.39k stars 253 forks source link

Cross namespace resource references #1777

Open a-hilaly opened 1 year ago

a-hilaly commented 1 year ago

Currently ACK controllers only allow within-same-namespace resource references . It would be nice to extend this feature to allow cross-namespace references and have a similar experience to resources secret fields. This is technically not very complicated to implement.

Runtime changes:

Code generator changes:

If anyone wanna give this a stab feel free to drop questions in this thread /good-first-issue /help-wanted

ack-prow[bot] commented 1 year ago

@A-Hilaly: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/aws-controllers-k8s/community/issues/1777): >Currently ACK controllers only allow [within-same-namespace resource references ](https://github.com/aws-controllers-k8s/community/blob/main/docs/design/proposals/resource-reference/cross-api-group.md#scope). It would be nice to extend this feature to allow cross-namespace references and have a similar experience to resources secret fields. This is technically not very complicated to implement. > >Runtime changes: >- https://github.com/aws-controllers-k8s/runtime/blob/main/apis/core/v1alpha1/identifiers.go#L72-L76 > >Code generator changes: >- After https://github.com/aws-controllers-k8s/code-generator/pull/435 merge - we need to stop passing the parent resource namespace and use the one mentioned in the ref field. > >If anyone wanna give this a stab feel free to drop questions in this thread >/good-first-issue >/help-wanted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
the-cybersapien commented 1 year ago

Hi! I'll take a stab at this!

/assign @the-cybersapien

ack-bot commented 10 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 8 months ago

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot commented 2 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale