search

aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.43k stars 257 forks source link

Allow RDS DbInstance to specify DBInstanceRoles #1833

Open dweebo opened 1 year ago

dweebo commented 1 year ago

Is your feature request related to a problem? We are using the DbInstance CRD to create RDS instances, for postgres engine. We have a specific project that wants to also setup s3export extension, per https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/postgresql-s3-export.html#USER_PostgreSQL.S3Export.InstallExtension

So we need to be able to set the IAM role on the Db Instance with feature s3Export. I don't see a way to do that today.

Describe the solution you'd like Add a new field to DbInstance CRD for an array of DBInstanceRoles. Pass those along to https://github.com/aws/aws-sdk-go/blob/main/service/rds/api.go#L26584 (at least that is where I think it would get set).

Describe alternatives you've considered For now we'll have to add this w/ custom post-creation hook of some kind that runs a aws cli command.

ack-bot commented 10 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

vmercierfr commented 8 months ago

We have the same use case, this is preventing us to deploy AWS ACK in production as well. Is this feature planned for future development?

a-hilaly commented 8 months ago

@vmercierfr i'm doing some work on RBS next week, putting this on my bucket.

vmercierfr commented 8 months ago

Awesome! Let me know if can help on this. (Meanwhile I'll read the contributor doc to see if I can contribute myself)

dcupif commented 3 months ago

Hi @a-hilaly, did you get the chance to move forward on this topic? This is still a limitation on your end. Feel free to let us know if we can help in any way.