aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.36k stars 248 forks source link

Sagemaker ACK S3 Object Version ID #1927

Open mwm5945 opened 8 months ago

mwm5945 commented 8 months ago

Is your feature request related to a problem? We'd like to be able to specify a specific version of an S3 Object to be pulled by Sagemaker for inference. This appears to be possible via Boto3, but not via the ACK. In particular, this can help mitigate the case where an object is overwritten, leading the incorrect object being pulled during scaling events, node replacements, etc.

Describe the solution you'd like The ability to specify in the model CR a specific version of an object to be pulled by Sagemaker.

Describe alternatives you've considered

a-hilaly commented 8 months ago

/cc @aws-controllers-k8s/sagemaker-maintainer

ryansteakley commented 8 months ago

@mwm5945 Can you show how this is done using boto3? I don't find any reference to pulling specific versions of S3 Objects in the https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker/client/create_model.html documentation? Once this is supported by the sdk we can support this in ACK

ack-bot commented 2 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale