search

aws-controllers-k8s / community

AWS Controllers for Kubernetes (ACK) is a project enabling you to manage AWS services from Kubernetes
https://aws-controllers-k8s.github.io/community/
Apache License 2.0
2.41k stars 254 forks source link

EC2 Controller sometimes doesn't delete the instance after the resource is deleted #2026

Open alanreji opened 8 months ago

alanreji commented 8 months ago

Describe the bug I see this issue where the EC2 controller doesn't delete an EC2 even after the resource is deleted. A parent resource of mine adopts the Instance resources here, and the deletion is cascaded from the parent resource. The first resource in the logs was created and deleted successfully and had the same manifest template. I also verified that monitoring is enabled in the resource manifest.

If I run kubectl get instances, I don't see this instance anymore, but I can see it in my AWS console.

The logs(Some texts have been redacted).

level":"info","ts":"2024-02-23T05:22:13.523Z","logger":"ackrt","msg":"created new resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-f7daacbd37-ec2-instance","is_adopted":false,"generation":1}
{"level":"info","ts":"2024-02-23T05:37:35.343Z","logger":"ackrt","msg":"deleted resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-f7daacbd37-ec2-instance","generation":4}
{"level":"info","ts":"2024-02-23T05:37:36.600Z","logger":"ackrt","msg":"created new resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","is_adopted":false,"generation":1}
{"level":"error","ts":"2024-02-23T05:37:36.750Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"8812e43a-1533-4ea4-9726-baf8a69d5171","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:36.777Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"f409a876-6f1e-4248-89a4-9cfd0887286f","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:36.808Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"f61e495a-5b4b-4082-97fd-ea7aaf83f622","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:36.848Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"ca23d1c5-63ce-4306-9ea7-4f7ea5286247","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:36.914Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"a62ba8a4-aafa-4239-84d8-51a4b992593d","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:37.019Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"223a7ffc-2e70-4006-9f3c-edc32dd2daee","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:37.201Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"3ad7f897-0928-43a4-82e5-0587edf8299c","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:37.542Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"25aa67c6-c88a-448a-8bb3-5459ae4c0b1c","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:38.203Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"4432fc77-3158-44be-b05a-9f06ef5fb37c","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:39.564Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"6a056a4a-fc14-4acc-b4e0-d8dd2b1f0123","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:42.155Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"7ac27fd0-6365-4a6b-a6b0-fad469bb10c4","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:47.302Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"93963266-e1cd-4e4c-ac13-4bc93163bb30","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:37:57.586Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"e6ff8d3c-b1d7-48bd-ae9e-c3f145190d66","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:38:18.095Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"97c008d4-8a8a-4237-829e-ad379b6be704","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:38:59.080Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"0ac56d21-0b69-4000-8860-2c1d638e5e09","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:40:21.024Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"360409f5-990b-4f30-9ded-7d39aa9a8887","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:43:04.906Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"be5ec100-acd8-4f3a-8f2f-d21b06dddf86","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:48:32.608Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"69dedfec-187d-4d53-a141-1e80f6370c43","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"error","ts":"2024-02-23T05:59:27.997Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":"example-service-81aa88bbb8-ec2-instance","namespace":"default"},"namespace":"default","name":"example-service-81aa88bbb8-ec2-instance","reconcileID":"264a906a-f3ca-47b1-8c29-01afdcce97a0","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
{"level":"info","ts":"2024-02-23T06:03:19.835Z","logger":"ackrt","msg":"created new resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-2bc0e24457-ec2-instance","is_adopted":false,"generation":1}
{"level":"info","ts":"2024-02-23T06:16:40.914Z","logger":"ackrt","msg":"deleted resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-2bc0e24457-ec2-instance","generation":4}
{"level":"info","ts":"2024-02-23T06:16:42.152Z","logger":"ackrt","msg":"created new resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-f0db9947ad-ec2-instance","is_adopted":false,"generation":1}
{"level":"info","ts":"2024-02-23T06:50:07.355Z","logger":"ackrt","msg":"deleted resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-f0db9947ad-ec2-instance","generation":4}
{"level":"info","ts":"2024-02-23T07:15:15.455Z","logger":"ackrt","msg":"created new resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-881dea2690-ec2-instance","is_adopted":false,"generation":1}
{"level":"info","ts":"2024-02-23T08:23:00.556Z","logger":"ackrt","msg":"deleted resource","account":"XXXXXXXXXXX","role":"","region":"eu-central-1","kind":"Instance","namespace":"default","name":"example-service-881dea2690-ec2-instance","generation":4}

Steps to reproduce It is reproducible only some of the time. It happens randomly with random instances.

Expected outcome The EC2 should be deleted once the resource is deleted.

Environment

a-hilaly commented 8 months ago

Hi @alanreji - there is a related issue here https://github.com/aws-controllers-k8s/community/issues/1759 . If you're using ArgoCD, can you try to switch to background deletion strategy?

alanreji commented 8 months ago

I don't use ArgoCD. I don't feel these two issues are related. The error logs are different. The delete log of 'example-service-81aa88bbb8-ec2-instance' is non-existent. All traces of that instance are lost from the Kubernetes cluster while it is running without anything controlling it.

alanreji commented 8 months ago

@a-hilaly It's always the same error.

{"level":"error","ts":"2024-02-29T22:33:19.063Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":" some-app-2-3fe1d6afdc-ec2-instance","namespace":"default"},"namespace":"default","name":" some-app-2-3fe1d6afdc-ec2-instance","reconcileID":"26bf9ec2-3f2e-4877-9ded-117ec6c61919","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}

It doesn't look like a 'delete' event issue. These error logs are generated even before that. I also noticed that instances that would not terminate wouldn't print an Instance ID if I tried 'kubectl get instances'. In contrast, the other instances have the Instance ID in place.

ack-bot commented 2 months ago

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot commented 1 day ago

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten