Open alanreji opened 8 months ago
Hi @alanreji - there is a related issue here https://github.com/aws-controllers-k8s/community/issues/1759 . If you're using ArgoCD, can you try to switch to background deletion strategy?
I don't use ArgoCD. I don't feel these two issues are related. The error logs are different. The delete log of 'example-service-81aa88bbb8-ec2-instance' is non-existent. All traces of that instance are lost from the Kubernetes cluster while it is running without anything controlling it.
@a-hilaly It's always the same error.
{"level":"error","ts":"2024-02-29T22:33:19.063Z","msg":"Reconciler error","controller":"instance","controllerGroup":"ec2.services.k8s.aws","controllerKind":"Instance","Instance":{"name":" some-app-2-3fe1d6afdc-ec2-instance","namespace":"default"},"namespace":"default","name":" some-app-2-3fe1d6afdc-ec2-instance","reconcileID":"26bf9ec2-3f2e-4877-9ded-117ec6c61919","error":"InvalidParameter: 1 validation error(s) found.\n- missing required field, RunInstancesInput.Monitoring.Enabled.\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}
It doesn't look like a 'delete' event issue. These error logs are generated even before that. I also noticed that instances that would not terminate wouldn't print an Instance ID if I tried 'kubectl get instances'. In contrast, the other instances have the Instance ID in place.
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close
.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten
Describe the bug I see this issue where the EC2 controller doesn't delete an EC2 even after the resource is deleted. A parent resource of mine adopts the
Instance
resources here, and the deletion is cascaded from the parent resource. The first resource in the logs was created and deleted successfully and had the same manifest template. I also verified thatmonitoring
is enabled in the resource manifest.If I run
kubectl get instances
, I don't see this instance anymore, but I can see it in my AWS console.The logs(Some texts have been redacted).
Steps to reproduce It is reproducible only some of the time. It happens randomly with random instances.
Expected outcome The EC2 should be deleted once the resource is deleted.
Environment