aws-deadline / deadline-cloud-for-after-effects

AWS Deadline Cloud for After Effects
Apache License 2.0
8 stars 9 forks source link

fix: move ae_adaptor and ae_submitter into deadline namespace #32

Closed epmog closed 5 months ago

epmog commented 5 months ago

What was the problem/requirement? (What/Why)

  1. When running pip install deadline-cloud-for-after-effects, it would install ae_adaptor into the site-packages, instead of in the deadline namespace package.
  2. When running the jsxbundler.py on Windows, it would error would with a "\P invalid syntax" on the help text of argparse

What was the solution? (How)

  1. include the deadline namespace for targets, this then also includes the ae_submitter in the pip install, even
  2. just swap the slash in the help text

What is the impact of this change?

Users can get further in this alpha intergration without experiencing roadblocks immediately.

How was this change tested?

hatch run fmt
hatch run lint
hatch build
hatch run test

I then pip-installed the local build and confirmed that it put the submitter and adaptor within the deadline namespace.

Was this change documented?

N/A

Is this a breaking change?

Fixing change :')


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud