aws-deadline / deadline-cloud-for-after-effects

AWS Deadline Cloud for After Effects
Apache License 2.0
8 stars 9 forks source link

feat: Include ipc.jsx file in PyPi Wheel #37

Closed Ahuge closed 3 months ago

Ahuge commented 4 months ago

What was the problem/requirement? (What/Why)

When installing the deadline cloud for after effects adaptor from PyPi, there was no included ipc.jsx file. This caused renders to not work.

What was the solution? (How)

The repository included instructions on building the ipc.jsx file. This PR includes the ipc.jsx in the hatch build command and updates the github release_publish.yml action to jsxbundle the clientipc before running hatch build.

What is the impact of this change?

The PyPi wheel files will now include the ipc.jsx file

How was this change tested?

Tested locally

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

N/A

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

Was this change documented?

N/A

Is this a breaking change?

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud