aws-deadline / deadline-cloud-for-after-effects

AWS Deadline Cloud for After Effects
Apache License 2.0
8 stars 9 forks source link

feat: Include custom Adobe Font files in the submitter job #46

Open Ahuge opened 3 months ago

Ahuge commented 3 months ago

What was the problem/requirement? (What/Why)

When a user uses Adobe Fonts, those custom fonts get installed in their appdata directory and are not included in the job. The resulting render does not have the correct fonts.

What was the solution? (How)

We query the scene and collect all of the custom adobe fonts. These fonts are uploaded as job attachments and the adaptor will install the fonts for the currently running user during the launch of After Effects. When After Effects is closed, the fonts are uninstalled.

What is the impact of this change?

After Effects renders that use custom Adobe Fonts render correctly

How was this change tested?

I have tested it running a modified version of the standard AfterEffects submitter template with a local session-runner. These files can be found here: https://gist.github.com/Ahuge/ab8da83c16e5ceadb8683bbde4d9155a The main change in the template was goofing around with my VirtualEnv as a JobEnvironment

I will deploy this to my own Deadline farm and confirm things there as well.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

Was this change documented?

Not yet

Is this a breaking change?

I suppose?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ahuge commented 3 months ago

Will need a rebase once #44 gets merged in.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
13.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud