aws-deadline / deadline-cloud-for-after-effects

AWS Deadline Cloud for After Effects
Apache License 2.0
8 stars 9 forks source link

fix logic around setting render parameters #48

Closed yuanmich2 closed 2 months ago

yuanmich2 commented 3 months ago

What was the problem/requirement?

The adaptor was rendering the entire composition every task.

What was the solution?

The old code was editing the composition, but not the output module of the render queue item already in the render queue. This PR uses timeSpanStart and timeSpanDuration to properly set the render queue item's frame range.

What is the impact of this change?

You can actually distribute render across multiple nodes by having different workers work on different frames.

How was this change tested?

By running render jobs on an EC2 CMF worker in my AWS account.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

I don't know where the tests are.

Was this change documented?

The change brings the code in line with how the adaptor is documented to work.

Is this a breaking change?

no


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.