aws-deadline / deadline-cloud-for-cinema-4d

AWS Deadline Cloud for Cinema 4D
Apache License 2.0
6 stars 8 forks source link

feat: Updates to work towards a GA release #59

Open Ahuge opened 2 months ago

Ahuge commented 2 months ago

What was the problem/requirement? (What/Why)

deadline-cloud-for-cinema-4d is an "alpha release" and during my testing trying to get this up and running on a customer managed fleet on AWS I have had to make several changes to get it working correctly.

What was the solution? (How)

Each of these commits are aimed to be mostly separate features or fixes however in my testing some of them do build on others.

How was this change tested?

I have been working with and using farm-2573f61b9d784c7fa38e61dbdc39172f to do all of my testing. This testing implements fixes that get us ready for a Linux render node worker, but currently appear to only work for 2024+. I have tested it on R26 and am getting hanging on launch (unrealted to Deadline as far as I can tell). Once I determine how to get that working, I will implement another PR with R26 fixes potentially.

Was this change documented?

Yes see DEVELOPMENT.md

Is this a breaking change?

No, the Linux support is a feature and the environment variable support is an optional feature

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

epmog commented 3 weeks ago

Thanks for the PR Alex! Mostly just the question around debug and if that can be removed now. Otherwise this looks pretty good!