aws-deadline / deadline-cloud-for-cinema-4d

AWS Deadline Cloud for Cinema 4D
Apache License 2.0
9 stars 12 forks source link

fix: Resolve issues with create_adaptor_packaging_artifact and depsBundle #82

Closed karthikbekalp closed 2 weeks ago

karthikbekalp commented 2 weeks ago

What was the problem/requirement? (What/Why)

There were 2 issues that I noticed on the 2 scripts:

What was the solution? (How)

Fixed the typos and confirmed that the scripts were working successfully.

And running the scripts created the dependency bundles in the dependency_bundle folder.

What is the impact of this change?

This will help with our release process.

How was this change tested?

Here's the output from running the create_adaptor_packaging_artifact.sh script.

$ bash scripts/create_adaptor_packaging_artifact.sh 
+ APP=cinema4d
+ APP_WITH_HYPEN=cinema-4d
+ MODULE_CAPITAL_D=Cinema4D
+ ADAPTOR_NAME=deadline-cloud-for-cinema-4d
+++ dirname scripts/create_adaptor_packaging_artifact.sh
++ realpath scripts
+ SCRIPTDIR=/local/home/pattatk/bealine-clients/deadline-cloud-for-cinema-4d/scripts
+ SOURCE=0
...
/bealine-clients/deadline-cloud-for-cinema-4d
+ cleanup_workdir
+ echo 'Cleaning up adaptor-pkg.xrDprDEPQX'
Cleaning up adaptor-pkg.xrDprDEPQX
+ rm -rf adaptor-pkg.xrDprDEPQX

This also created cinema4d-openjd-py3.11-linux-64-0.3.4.dist-info.tar.gz file.

Here's the output from running the depsBundle.sh script.

$ bash depsBundle.sh 
+ python depsBundle.py
Looking in indexes: https://aws:****@amazon-deadline-cloud-938076848303.d.codeartifact.us-west-2.amazonaws.com/pypi/amazon-deadline-cloud-client-software/simple/
Collecting deadline==0.48.*
...
+ rm -f dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps-windows.zip
+ rm -f dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps-linux.zip
+ rm -f dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps-macos.zip
+ cp dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps.zip dependency_bundle/deadline_cloud_for_cinema4d_submitter-deps-windows.zip
+ cp dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps.zip dependency_bundle/deadline_cloud_for_cinema4d_submitter-deps-linux.zip
+ cp dependency_bundle/deadline_cloud_for_cinema_4d_submitter-deps.zip dependency_bundle/deadline_cloud_for_cinema4d_submitter-deps-macos.zip

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud