When detecting if a parameter is a path or file, evaluate the parameter first to resolve the references and attach the expanded path. Also ignore op: data references which are not files.
What is the impact of this change?
Directories are detected. References in file and directory names are handled correctly. Data references are ignored.
How was this change tested?
Expanded unit tests. For manual testing, I created a file cache inside a geometry node and pointed the file cache to directories both with $HIP as part of the path and without it. I then opened the Deadline Cloud node and clicked "Parse files". The files and directories were correctly detected and attached.
Was this change documented?
No documentation needed.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
What was the problem/requirement? (What/Why)
There were several related bugs with automatically detecting and attaching files:
What was the solution? (How)
When detecting if a parameter is a path or file, evaluate the parameter first to resolve the references and attach the expanded path. Also ignore
op:data references which are not files.What is the impact of this change?
Directories are detected. References in file and directory names are handled correctly. Data references are ignored.
How was this change tested?
Expanded unit tests. For manual testing, I created a file cache inside a geometry node and pointed the file cache to directories both with
$HIPas part of the path and without it. I then opened the Deadline Cloud node and clicked "Parse files". The files and directories were correctly detected and attached.Was this change documented?
No documentation needed.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.