aws-deadline / deadline-cloud-for-houdini

AWS Deadline Cloud for Houdini
Apache License 2.0
12 stars 10 forks source link

fix: verify Deadline Cloud render node input exists before submitting #137

Closed joel-wong-aws closed 5 months ago

joel-wong-aws commented 5 months ago

What was the problem/requirement? (What/Why)

If the Deadline Cloud ROP does not have an input ROP, then submission of a job will first hash and upload all the files for the job, then attempt to submit the job, then get a confusing error message related to missing steps.

What was the solution? (How)

The error is caused by missing an input ROP, but the the message is confusing. Added verification that there is an input ROP at the start of the submission.

What is the impact of this change?

Easier onboarding for customers

How was this change tested?

  1. Created a simple render with spheres, light, and camera
  2. Created a Mantra ROP
  3. Created a Deadline Cloud ROP, but did not connect it to the Mantra ROP
  4. Click "Submit" in the Deadline ROP

Before: image

After: image

Was this change documented?

No, not necessary

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.