search

aws-deadline / deadline-cloud-for-houdini

AWS Deadline Cloud for Houdini
Apache License 2.0
12 stars 10 forks source link

fix: pass through log verbosity #141

Closed joel-wong-aws closed 5 months ago

joel-wong-aws commented 5 months ago

Resolves https://github.com/aws-deadline/deadline-cloud-for-houdini/issues/120

What was the problem/requirement? (What/Why)

The logging verbosity for Mantra and Karma renders can be configured through the Mantra or Karma node and this is passed through to the Deadline Cloud render.

What was the solution? (How)

Currently, this value is hardcoded to 3. Removing this code passes through the log verbosity specified in the Mantra or Karma node.

Also noted that Karma was incorrectly labeled as having a node type "Driver/karma" rather than "Driver/usdrender", so updated that everywhere.

What is the impact of this change?

Log verbosity can be specified in Deadline Cloud renders, and progress is output by default in Karma for easier tracking.

How was this change tested?

  1. Created a simple scene with geometry, light, and camera
  2. Created a Mantra node and Deadline Cloud node, connected the Mantra node output to the Deadline Cloud node input
  3. Adjusted the Mantra log verbosity under Rendering > Statistics >Verbose Level
  4. Submitted renders with different verbosity levels and confirmed that verbosity of logs changed accordingly
  5. Created a Karma node and unlocked it
  6. Introspected into the Karma node and adjusted the USD Render node > Husk > Statistics > Verbosity
  7. Submitted renders with different verbosity levels and confirmed that verbosity of logs changed accordingly

Was this change documented?

No, not required

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

epmog commented 5 months ago

Looks like some tests are failing too, so whatever the changes ends up being, we'll have to update them as well.