search

aws-deadline / deadline-cloud-for-houdini

AWS Deadline Cloud for Houdini
Apache License 2.0
12 stars 10 forks source link

fix: improve error messages when farm or queue ID not defined #148

Closed joel-wong-aws closed 5 months ago

joel-wong-aws commented 5 months ago

What was the problem/requirement? (What/Why)

When first submitting a job to AWS Deadline Cloud using its render node, I received unexpected error messages with an Access Denied error. These were related to missing default farms and queues.

image

What was the solution? (How)

Added a check whether the farm and queue are defined before calling GetQueue in the submitter.

image

image

What is the impact of this change?

Easier onboarding for new customers

How was this change tested?

  1. Created a simple scene with geometry, light, camera
  2. Connected a Karma ROP to the Deadline Cloud ROP
  3. Clicked submit (without adding settings, or after clearing the default farm and queue with deadline config set defaults.farm_id "" and deadline config set defaults.queue_id "")

Was this change documented?

No, not required

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS-Samuel commented 5 months ago

Thanks for fixing this bug! The changes here look good, but it looks like we could add the same logic to

  • settings_callback
  • login_callback
  • update_queue_parameters_callback

in src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py

Which would allow us to resolve #117

Do you mind adding the checks for unset farm/queue there too?

After syncing offline, we've agreed to tackle these other places in a future PR

Ship it :shipit: