aws-deadline / deadline-cloud-for-houdini

AWS Deadline Cloud for Houdini
Apache License 2.0
12 stars 10 forks source link

feat!: run simulations sequentially #149

Closed crowecawcaw closed 4 months ago

crowecawcaw commented 5 months ago

What was the problem/requirement? (What/Why)

The submitter previously always rendered each frame as a task, and tasks would be distributed to different Deadline Cloud workers. But some node types like simulations must be run sequentially - each frame depends on the previous one.

What was the solution? (How)

Introduce a new sequential rendering strategy where all frames are rendered inside a single Deadline Cloud task which ensures they are sequentially on a single worker.

Specific changes include:

What is the impact of this change?

Simulations are run efficiently.

How was this change tested?

I submitted a hip file with simulations and regular rendering. The simulations resulted in single tasks and the renders resulted in 1 task per frame.

Was this change documented?

No, but it needs to be.

Is this a breaking change?

No. Changing the runData schema could have been a breaking change, but I took care to ensure the old frame parameter is still handled correctly.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

epmog commented 4 months ago

Regardless of if openjd-adaptor-runtime keeps the interface version, we can delay the decision by bumping it regardless.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud