aws-deadline / deadline-cloud-for-houdini

AWS Deadline Cloud for Houdini
Apache License 2.0
12 stars 10 forks source link

fix: add missing submission telemetry event #158

Closed lucaseck closed 4 months ago

lucaseck commented 4 months ago

What was the problem/requirement? (What/Why)

Missing a telemetry event for submissions

What was the solution? (How)

Add the event

What is the impact of this change?

No more missing telemetry

How was this change tested?

Ran a submission and saw the event record

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

epmog commented 4 months ago

Nice! Should we also be adding one for exceptions raised in submission? ie. lines 674-678

Would look something like: https://github.com/aws-deadline/deadline-cloud/blob/041550c40002e3a2d1b77a77530318212cf10b5d/src/deadline/client/ui/dialogs/submit_job_to_deadline_dialog.py#L487-L492

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud