aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 16 forks source link

feat: Add the ability to specify a render region #176

Closed mwiebe closed 1 month ago

mwiebe commented 1 month ago

See also the related PR https://github.com/aws-deadline/deadline-cloud-samples/pull/37

What was the problem/requirement? (What/Why)

Alison Hardy's blog post https://aws.amazon.com/blogs/media/create-a-tile-rendering-job-with-modifications-for-aws-deadline-cloud/ does a great job walking through the development process to create a tile render job. I gave her some ideas for how to update her deadline-cloud-for-maya change to get it merged, but she didn't have sufficient time at the end of her internship to finish that.

What was the solution? (How)

I've completed the changes I suggested to switch the tiling parameters into more general region render parameters.

This builds on the work of @alichiba. I have adjusted the change from tile index parameters into region render parameters. This works for the tile render case as well as for other region rendering.

Also refactor how the image resolution gets set, switching it from render function parameters to setting properties in the scene.

Commit from @alichiba:

feat: add tile rendering configuration to arnold handler

What is the impact of this change?

Once we merge a corresponding change to provide a tile rendering sample job bundle, customers will be able to run tile renders with Maya/Arnold and FFmpeg on Deadline Cloud.

How was this change tested?

I built my changes into a maya-openjd conda package that I published to an S3 conda channel, and submitted a tile render job and the turntable job. Both of these use the adaptor, without using the submitter.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.


Timestamp: 2024-09-25T17:28:33.011626-07:00
Running job bundle output test: C:\Dev\deadline-cloud-for-maya\job_bundle_output_tests\cube

cube
Test succeeded

Timestamp: 2024-09-25T17:28:34.822302-07:00
Running job bundle output test: C:\Dev\deadline-cloud-for-maya\job_bundle_output_tests\layers

layers
Test succeeded

Timestamp: 2024-09-25T17:28:36.332334-07:00
Running job bundle output test: C:\Dev\deadline-cloud-for-maya\job_bundle_output_tests\layers_no_variation

layers_no_variation
Test succeeded

Timestamp: 2024-09-25T17:28:37.027234-07:00
Running job bundle output test: C:\Dev\deadline-cloud-for-maya\job_bundle_output_tests\referenced_layers

referenced_layers
Test succeeded

Timestamp: 2024-09-25T17:28:38.239517-07:00
Running job bundle output test: C:\Dev\deadline-cloud-for-maya\job_bundle_output_tests\renderman
Skipping test renderman because Renderman for Maya is not installed.
All tests passed, ran 4 total.
Timestamp: 2024-09-25T17:28:40.213306-07:00

Was this change documented?

Updated the schemas for the init-data/run-data additions.

Is this a breaking change?

No, this adds new options without removing/changing the existing ones.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
39.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud