aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 16 forks source link

fix: maya 2025 submitter failed to load due to qt setMargin being removed #192

Closed epmog closed 6 days ago

epmog commented 6 days ago

What was the problem/requirement? (What/Why)

Tried submiting jobs from Maya 2025 and ran into a stack trace when loading the scene settings tab. PySide6 was complaining that setMargin no longer exists.

It was deprecated in qt5, and removed in qt6

ref: https://doc.qt.io/qt-5/qlayout-obsolete.html#setMargin

What was the solution? (How)

Recommendation is to use setContentsMargin instead, which we already were. So I've deleted the problematic line.

I've also updated the dev install (hatch run install) to support Maya 2025 which uses python 3.11. On macOS, 2023 was the last year that relied on rosetta, so I've fixed the dependencies discovery for it.

What is the impact of this change?

Maya 2025 can launch and submit jobs!

How was this change tested?

Admittedly, I did not test the render.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

But I did test the job bundle output tests. Looks like arnold now defaults to true for failing on missing licenses, so I'm now forcibly setting the option in the scenes we have. We probably need to add the ability to differentiate expected output per version.


Timestamp: 2024-10-30T15:50:50.623033-05:00
Running job bundle output test: /Users/morgane/dev/github/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test succeeded

Timestamp: 2024-10-30T15:50:51.401506-05:00
Running job bundle output test: /Users/morgane/dev/github/deadline-cloud-for-maya/job_bundle_output_tests/referenced_layers

referenced_layers
Test succeeded

Timestamp: 2024-10-30T15:50:51.746398-05:00
Running job bundle output test: /Users/morgane/dev/github/deadline-cloud-for-maya/job_bundle_output_tests/renderman
Skipping test renderman because Renderman for Maya is not installed.
Timestamp: 2024-10-30T15:50:51.746537-05:00
Running job bundle output test: /Users/morgane/dev/github/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test succeeded

Timestamp: 2024-10-30T15:50:52.042350-05:00
Running job bundle output test: /Users/morgane/dev/github/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test succeeded

All tests passed, ran 4 total.
Timestamp: 2024-10-30T15:50:54.232503-05:00

Was this change documented?

Yes

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud