aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 16 forks source link

refactor: Function rename from upcoming deadline-cloud change #27

Closed jlangmann-aws closed 1 year ago

jlangmann-aws commented 1 year ago

What was the problem/requirement? (What/Why)

NOTE: Do not merge until https://github.com/casillas2/deadline-cloud/pull/35 is merged

The upcoming change to deadline cloud PR https://github.com/casillas2/deadline-cloud/pull/35 renamed the deadline dialog on_save_bundle function to on_export_bundle.

What was the solution? (How)

Rename the on_save_bundle call

What is the impact of this change?

None

How was this change tested?

Tested running the output tests

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes, test failures are unrelated to my change.


Timestamp: 2023-09-21T01:06:50.570776+00:00
Running job bundle output test: /home/rocky/git/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: deadline:targetTaskRunStatus
   value: READY
 - name: deadline:maxFailedTasksCount

Timestamp: 2023-09-21T01:06:52.565262+00:00
Running job bundle output test: /home/rocky/git/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -46,7 +46,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Timestamp: 2023-09-21T01:06:53.233449+00:00
Running job bundle output test: /home/rocky/git/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Failed 3 tests, succeeded 0.
Timestamp: 2023-09-21T01:06:55.067857+00:00

Was this change documented?

No, this is a change to running the test cases.

Is this a breaking change?

Yes, requires updated version of deadline-cloud