aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 16 forks source link

chore(deps)!: Update to openjd-runtime-adaptor #32

Closed agerveshi closed 1 year ago

agerveshi commented 1 year ago

BEA-16122

What was the problem/requirement? (What/Why)

deadline and openjd dependencies needed to be updated as there are breaking changes in the backend.

What was the solution? (How)

move to latest deadline and move to openjd-adaptor-runtime as openjd has been deprecated.

What is the impact of this change?

Maya job submissions will work again

How was this change tested?

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

The tests are failing because RenderSetupIncludeLight is false, but this seems to be a user-specific setting. I will investigate further.

Timestamp: 2023-10-06T19:58:19.951958+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: deadline:targetTaskRunStatus
   value: READY
 - name: deadline:maxFailedTasksCount

Timestamp: 2023-10-06T19:58:20.279787+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -46,7 +46,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Timestamp: 2023-10-06T19:58:20.890610+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Failed 3 tests, succeeded 0.
Timestamp: 2023-10-06T19:58:23.452759+00:00

Was this change documented?

Yes, updated repo documentation

Is this a breaking change?

Yes, breaking dependency changes