aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 12 forks source link

Adding VRay Support #68

Closed ttblanchard closed 7 months ago

ttblanchard commented 8 months ago

What was the problem/requirement? (What/Why)

The existing Adaptor and Submitter don't support VRay Renders

What was the solution? (How)

Added a VRay handler to the Adaptor.

What is the impact of this change?

You can now use VRay as the render engine for Maya Jobs

How was this change tested?

Wrote and ran unit tests.

Also had a successful run of a VRay + Maya render in CMF.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

No, changes are only in the adaptor

Was this change documented?

no

Is this a breaking change?

No

epmog commented 8 months ago

Unless I missed something, I don't think we've set up the adaptor in a way to easily allow renderhandlers to add their own progress/error messages per workflow without dealing with other workflows? Right now we have to add if-statements to this function based on the workflow, rather than adding it to the render handler.

ref: https://github.com/casillas2/deadline-cloud-for-maya/blob/8b0ffa8880df58ee953356c3c403ab545054aa6d/src/deadline/maya_adaptor/MayaAdaptor/adaptor.py#L187-L192

My question there would be, do we need additional handlers for vray

ttblanchard commented 8 months ago

Unless I missed something, I don't think we've set up the adaptor in a way to easily allow renderhandlers to add their own progress/error messages per workflow without dealing with other workflows? Right now we have to add if-statements to this function based on the workflow, rather than adding it to the render handler.

ref:

https://github.com/casillas2/deadline-cloud-for-maya/blob/8b0ffa8880df58ee953356c3c403ab545054aa6d/src/deadline/maya_adaptor/MayaAdaptor/adaptor.py#L187-L192

My question there would be, do we need additional handlers for vray

I added a handler for Vray license errors, for which I found the text here: https://docs.chaos.com/display/VMAYA/Troubleshooting