aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya
Apache License 2.0
11 stars 12 forks source link

fix: use right mode when opening toml file #90

Closed AWS-Samuel closed 7 months ago

AWS-Samuel commented 7 months ago

What was the problem/requirement? (What/Why)

tomllib expects files to be opened in binary mode. toml expects otherwise.

What was the solution? (How)

Set the mode depending on the python version.

What is the impact of this change?

Deps bundle works on 3.11

How was this change tested?

Referenced houdini https://github.com/casillas2/deadline-cloud-for-houdini/blob/mainline/scripts/_project.py#L23

This is also the only toml usage.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

No, this is not integration code.

Was this change documented?

No

Is this a breaking change?

No