fix: set optionVar value to default before running tests, small additional fixes - Githubissues

aws-deadline / deadline-cloud-for-maya

AWS Deadline Cloud for Maya

Apache License 2.0

11 stars 15 forks source link

fix: set optionVar value to default before running tests, small additional fixes #91

Open rmv opened 8 months ago

rmv commented 8 months ago

What was the problem/requirement? (What/Why)

Bundle tests rely on a maya option var that is saved in preferences, not scene file.
When the report file path is shown, the report is not yet created.
Macos does not show Qt dialog window titles.
Coverage tests include some test code.

What was the solution? (How)

Set the option Var to its default value before running the tests.
Before reporting the report file location, make sure it's fully written out.
Repeat the title info in dialog body.
Omit test code from coverage testing.

What is the impact of this change?

More reliable output bundle tests, minor qol fixes for devs.

How was this change tested?

Ran the bundle output tests in failure and success modes.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes.

Was this change documented?

No

Is this a breaking change?

No

epmog commented 7 months ago

I ended up with a very similar fix in https://github.com/casillas2/deadline-cloud-for-maya/pull/103 that got merged and didn't see that the work was already done here. ~~Closing this.~~ actually there's other fixes in here that we want in

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud