aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

feat!: add windows support to worker fixture #115

Closed moorec-aws closed 3 months ago

moorec-aws commented 3 months ago

What was the problem/requirement? (What/Why)

Add Windows support to the worker fixture.

What was the solution? (How)

Add Windows support to the worker fixture.

What is the impact of this change?

Adds Windows support to the worker fixture.

How was this change tested?

Ran the e2e tests from the deadline-worker-agent repository and confirmed they passed:

hatch run windows-e2e-test
hatch run linux-e2e-test

Set export WORKER_AGENT_WHL_PATH=/home/user/Projects/git/deadline-cloud-worker-agent/dist/deadline_cloud_worker_agent-0.27.0.post1.dev22-py3-none-any.whl

Confirmed that the dev version was installed on the worker:

C:\Windows\system32> pip list
Package                     Version
--------------------------- ------------------
deadline-cloud-worker-agent 0.27.0.post1.dev22

Set export AWS_ENDPOINT_URL_DEADLINE=<custom-endpoint>

Confirmed that that it failed because the resource ids were not at that endpoint

Was this change documented?

No

Is this a breaking change?

Yes


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud