search

aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

fix: check value of operating_system.name instead of operating_system #117

Closed ttblanchard closed 3 months ago

ttblanchard commented 3 months ago

What was the problem/requirement? (What/Why)

When running the tests I noticed that the fixtures were incorrectly detecting the OS type and trying to use Windows paths on my linux worker hosts.

What was the solution? (How)

Changed operating_system == 'AL2023' to operating_system.name == 'AL2023' in two places.

What is the impact of this change?

The fixtures should work

How was this change tested?

Ran tests with both Linux and Windows worker hosts.

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.