search

aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

refactor: Refactor JA integ test resource creation so that we use some resources from the environment #119

Closed YutongLi291 closed 3 months ago

YutongLi291 commented 3 months ago

(refactor: Refactor JA integ test resource creation so that we use some resources from the environment)

https://github.com/aws-deadline/deadline-cloud/pull/373 Needs to be merged alongside this PR.

What was the problem/requirement? (What/Why)

For the Job Attachments integ tests, we are currently creating farm/bucket resources for each test run. There is no need to do so and we can use the existing farm/bucket in the environment to save resources and also avoid adding more permissions.

What was the solution? (How)

Refactor the integ tests fixtures for Job Attachments so that some resources like Farm and Bucket are taken in from the environment.

What is the impact of this change?

Less permissions and resources needed to run the JA integ tests.

How was this change tested?

Tested by using hatch run integ:test in the deadline-cloud package with changes from https://github.com/aws-deadline/deadline-cloud/pull/373 and confirmed that the Job Attachment tests passed.

Was this change documented?

This is a small test refactor.

Is this a breaking change?

No. The tests were never ran before as a workflow anyway.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jericht commented 3 months ago

https://github.com/aws-deadline/deadline-cloud/pull/373 Needs to be merged alongside this PR.https://github.com/aws-deadline/deadline-cloud/pull/373 Needs to be merged alongside this PR.https://github.com/aws-deadline/deadline-cloud/pull/373 Needs to be merged alongside this PR.

Since the deadline-cloud repo is not actually running the JA tests in any CIs, we technically are OK to do this for now. Normally, we would actually need to merge this PR first, release this package, then we can merge the deadline-cloud PR (and if necessary, bump its dependency on this package). Reason is that the tests on deadline-cloud would fail since this package isn't consumable by the CI yet.. but there are no tests running yet, so we are OK for now.