aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

fix: BYO Deadline now looks specifically for resource env vars. #128

Closed erico-aws closed 3 months ago

erico-aws commented 3 months ago

What was the problem/requirement? (What/Why)

The fields of DeadlineResources don't match the kwargs in it's constructor. Either, you don't provide FARM, FLEET and QUEUE and the required field validation fails OR you do provide them and the constructor for DeadlineResources fails because it doesn't recognize a keyword named farm.

What was the solution? (How)

We're going to leave validation of required fields to the dataclass itself. Pull the specific env vars we want out for specifying the resources.

What is the impact of this change?

Unblocks BYO Deadline testing workflows.

How was this change tested?

I have an existing Farm, Fleet and Queue. I was able to use these fixtures to run tests against them. My account is limited to on 2 Farms (which I already have) if this didn't work I would have gotten errors making a new Farm.

Was this change documented?

No.

Is this a breaking change?

No.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.