aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

fix: increase number of retries for SSM send_command to 60 #140

Closed YutongLi291 closed 1 month ago

YutongLi291 commented 1 month ago

What was the problem/requirement? (What/Why)

Windows workers boot up takes longer than Linux workers, so the current total retry time to verify that we can send an SSM command, which is 5 minutes is not sufficient, in rare cases.

What was the solution? (How)

Increase the timeout for sending an SSM command on a launched EC2 instance.

What is the impact of this change?

More slack in waiting for the windows worker to be booted, less flakiness

How was this change tested?

hatch run fmt

Pulled the worker agent package and installed this version of test-fixtures, confirmed that the timeout was increase and it successfully waited for the worker to start.

Was this change documented?

no

Is this a breaking change?

no

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud