aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

fix: start windows worker service depending on the worker configuration #144

Closed YutongLi291 closed 1 month ago

YutongLi291 commented 1 month ago

What was the problem/requirement? (What/Why)

The Posix deadline-worker service started depending on whether the worker configuration had start_service set to True or False, but the WIndows service did not.

What was the solution? (How)

Also make the WIndows service dependent on the worker configuration in specifying whether the service should start after the install.

What is the impact of this change?

Better and more consistent testing experience across Windows and Posix

How was this change tested?

hatch run fmt, hatch build

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud