aws-deadline / deadline-cloud-test-fixtures

This package contains pytest fixtures that are used to test AWS Deadline Cloud Python packages
Apache License 2.0
9 stars 13 forks source link

fix: convert JobRunAsUser to dict before passing to boto call #28

Closed jericht closed 12 months ago

jericht commented 12 months ago

What was the problem/requirement? (What/Why)

We recently added a required job_run_as_user field to our Queue creation but passed the incorrect type to our boto CreateQueue call (JobRunAsUser instead of dict)

Note: I gave the OK to release the previous changes as a patch version, but I was wrong, it should've been a minor version bump because users need to update calls to Queue.create to use the new required param. Since we're already in a situation with a breaking change as a patch version, I'll also release this change as a patch version since it fixes a bug in the last patch.

What was the solution? (How)

Convert the dataclass to a dict in our boto call

What is the impact of this change?

It works

How was this change tested?

Ran worker agent integ tests. See https://github.com/casillas2/deadline-cloud-worker-agent/pull/57

Was this change documented?

No

Is this a breaking change?

No