aws-deadline / deadline-cloud-worker-agent

The AWS Deadline Cloud worker agent can be used to run a worker in an AWS Deadline Cloud fleet.
Apache License 2.0
15 stars 21 forks source link

test: add test that verifies subsequent tasks are NEVER_ATTEMPTED when previous action is canceled #437

Closed YutongLi291 closed 3 weeks ago

YutongLi291 commented 1 month ago

What was the problem/requirement? (What/Why)

The scheduler doesn’t pipeline more than one task run in a session until the first task run in that session has completed.

We should verify that this behaviour is as expected, and that if the task run is not completed, other tasks should not have been attempted.

What was the solution? (How)

Add an E2E test that verifies that when a task is canceled during its run, the subsequent tasks are in NEVER_ATTEMPTED status.

Also edited an existing test that verifies CANCELED actions that other subsequent actions are NEVER_ATTEMPTED

What is the impact of this change?

Better testing to verify worker behaviour is as expected when task is canceled, that following tasks are NEVER_ATTEMPTED

How was this change tested?

# Linux
source .e2e_linux_infra.sh
hatch run e2e-test

# Windows
source .e2e_windows_infra.sh
hatch run e2e-test

Was this change documented?

No

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud