aws-deadline / deadline-cloud-worker-agent

The AWS Deadline Cloud worker agent can be used to run a worker in an AWS Deadline Cloud fleet.
Apache License 2.0
15 stars 21 forks source link

test: add windows test that worker service restarts process #451

Closed YutongLi291 closed 3 weeks ago

YutongLi291 commented 4 weeks ago

What was the problem/requirement? (What/Why)

On windows, the worker agent creates a service when running install-deadline-worker (without the --no-service argument). One responsibility of this service is to restart the worker agent process if it exits (e.g. a program crash).

We require automated end-to-end testing to ensure this functionality works as expected.

What was the solution? (How)

Add a test that verifies that when windows worker shuts down by a SIGKILL signal, the worker service restarts the process.

Also moved around the other test in this class, so that we do not have to create 2 workers in this class, rather than one.

What is the impact of this change?

Better code quality for the code that is responsible for restarting the worker.

How was this change tested?

source .e2e_windows_infra.sh
hatch run e2e-test

Was this change documented?

No

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud