search

aws-deadline / deadline-cloud-worker-agent

The AWS Deadline Cloud worker agent can be used to run a worker in an AWS Deadline Cloud fleet.
Apache License 2.0
15 stars 21 forks source link

chore(test): fixes testing race when calling Session._action_updated_impl #454

Closed ddneilson closed 3 weeks ago

ddneilson commented 3 weeks ago

What was the problem/requirement? (What/Why)

Unit tests that call Session._action_updated_impl() were randomly failing because that function does some work in a Future, and the tests were not waiting for the future to complete before checking results. The future would usually complete quickly, but when it doesn't then the tests would fail.

What was the solution? (How)

Fix the tests by exposing the inner future and waiting on it during the tests.

What is the impact of this change?

Less thrashing trying to get CI tests to pass.

How was this change tested?

Just running the unit tests a bunch of times.

Was this change documented?

N/A

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
20.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud