aws-deadline / deadline-cloud-worker-agent

The AWS Deadline Cloud worker agent can be used to run a worker in an AWS Deadline Cloud fleet.
Apache License 2.0
15 stars 21 forks source link

feat: integrate with job attachment download cli as a openjd action run #476

Closed godobyte closed 3 days ago

godobyte commented 1 week ago

What was the problem/requirement? (What/Why)

Worker Agent runs sync_input and sync_output callbacks to interact with customer s3 as worker agent user. This brings the following problem

  1. job user is a more suitable user to run the sync process
  2. sync_input and sync_output handling in session polluted the purpose of the class

What was the solution? (How)

Worker Agent is in the process of changing Job Attachment sync input and sync output to use attachment and manifest commands running as job user.

What is the impact of this change?

This is still in development and is under a feature flag.

How was this change tested?

Locally set the feature flag, build and install whl files, run hatch deadline-worker-agent

Was this change documented?

It's currently only documented in the code docstring.

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud